[protobuf] Add _loaded_options to FileDescriptor#15677
Merged
JelleZijlstra merged 1 commit intopython:mainfrom May 2, 2026
Merged
[protobuf] Add _loaded_options to FileDescriptor#15677JelleZijlstra merged 1 commit intopython:mainfrom
JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
- pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobuf renamed
_loaded_optionsto_optionsin 6.x but continues to support the old name for compatibility with 5.x, which they explicitly still support (actually as this is about gencode, technically they still support back to 3.x)https://protobuf.dev/support/version-support/
As it is still there in the latest version of protobuf, I guess the stub should reflect that
https://github.com/protocolbuffers/protobuf/blob/760418056a557866afc31860297b9034ef9ade1e/python/google/protobuf/descriptor.py#L140
Note, this came up because #15569 did a good job of updating type definitions throughout - but it means that previously the result of
AddSerializedFilewasAnyand now it isFileDescriptor. This causes the latest version of typeshed to fail to typecheck 5.x gencode where previously it succeeded.